-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): add submerge for aspirate and dispense #17368
base: edge
Are you sure you want to change the base?
Conversation
Hey Shiyao! Don't forget to put the work in the move liquid tools behind the liquid classes feature flag: Additionally, the cypress migrations test will fail because we need to migrate the new submerge form fields. I am planning to create a 8.5.0 migration file after @ncdiehl11 cuts the 8.4.0 release branch. But you can add the new fields to that migration file once it is created. |
Hey @jerader, just confirming that 8.4.0 has been cut so you can safely merge the migration file to edge. No rush but ping us when you do. |
@ncdiehl11, since Shiyao added a few new fields to the |
`${tab}_delay_seconds`, | ||
mappedErrorsToField | ||
)} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll need to add our position field/modal here like designs specify for retract (see comment)
protocol-designer/src/steplist/formLevel/test/getDefaultsForStepType.test.ts
Show resolved
Hide resolved
Generally looking good! I'm going to mark as "do not merge" because in addition to addressing these comments, we need to make sure we add the migration as commented above once this merges |
Just merged in my touch tip refactor PR, so you should be able to add to the |
re AUTH-904, AUTH-905
Overview
In this PR, I added a Submerge section for aspirating and dispensing in the transfer step, but only when the liquid classes feature flag is enabled.
Test Plan and Hands on Testing
-Enable the liquid classes feature flag in the settings
-Add a transfer step and verify that the submerge field appears for both aspirating and dispensing
Changelog
-Added new submerge fields to 8_5_0 migration
Review requests
Risk assessment