Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): tune store_labware motion parameters and current to increase the z torque. #17382

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Jan 29, 2025

Overview

Motion parameters need to be adjusted to account for tiprack weight by decreasing the speed when moving on the z axis when storing labware. This pull request decreases the z speed to half the move speed and also decreases the current back down to 1.5mAmps since the lower speeds increase the torque.

Test Plan and Hands on Testing

  • Make sure we can store and dispense full tipracks and PCR plates

Changelog

  • decrease the speed to half when moving the z axis in the store_labware function for higher torque.
  • decrease the move and home current for the z axis back to 1.5mAmps since the higher torque makes up for the current.
  • fix an issue when storing motion_parameters

Review requests

Risk assessment

Low, unreleased.

@vegano1 vegano1 requested a review from a team as a code owner January 29, 2025 22:41
@vegano1
Copy link
Contributor Author

vegano1 commented Jan 29, 2025

thanks to @Carlos-fernandez for pointing this out.

Copy link
Contributor

@Carlos-fernandez Carlos-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vegano1 vegano1 merged commit ac70ce0 into edge Jan 30, 2025
20 of 24 checks passed
@vegano1 vegano1 deleted the flex-stacker-tune-store-labware branch January 30, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants