Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): introduce LiquidEntities and update ingredients JSON key to match #17385

Draft
wants to merge 4 commits into
base: edge
Choose a base branch
from

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jan 30, 2025

closes AUTH-1382

Overview

This PR introduces liquidEntities to InvariantContext so step-generation will have access to liquids and the liquid python name. As a result, the previous selector that stored liquid info, allIngredientNamesIds has been deprecated.

Test Plan and Hands on Testing

Test the whole journey of a liquid in PD:

  1. create a liquid, assign it to labware, move it around in a step
  2. check out overview and see that the liquid section is correct. check on the materials list modal and see that liquids are correct
  3. download the protocol and make sure it re-imports correctly
  4. import an old PD protocol and see that it imports correctly

This attached protocol has a bunch of liquids that you can use to test

Zymo_Magbead_DNA_Cells-Flex_96_channel Truly fixed (2).json

Changelog

  • add liquidEntities to InvariantContext
  • clean up ingredients in the json file and migrate it so it matches for all JSON files
  • update affected tests
  • use getLiquidEntities instead of ingredients when needed in order to deprecate the ingredients selector

Risk assessment

med

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant