-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Orleans 8.2 #163
Conversation
Hi @oising , are you working on RegisterGrainTimer? If so, do you have any ETA? Would you like some help? |
Yeah, that's the one. I think I'm okay? It will basically work the same as the legacy timer. The grain timer is meant to respect interleaving rules but I don't believe testkit does in general, so I don't have much to do to implement. |
That's correct, the TestKit does not implement any special threading controls. It's up to the unit test implementer to ensure the grain instance is correctly called in a single-threaded fashion. (And anyone looking for managed single-threaded execution should turn to the Orleans TestCluster.) |
@jkonecki @seniorquico I'll have the PR ready for review for end of day today. |
Ready for first review. |
Looks good to me, thank you! Leaving to @seniorquico to review and approve. |
Update OrleansTestKit to work with Orleans 8.2
closes #164