Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Orleans 8.2 #163

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Update for Orleans 8.2 #163

merged 3 commits into from
Jul 19, 2024

Conversation

oising
Copy link
Contributor

@oising oising commented Jul 12, 2024

Update OrleansTestKit to work with Orleans 8.2

  • update Orleans nugets
  • add missing methods on modified interfaces
  • add testkit wiring for new RegisterGrainTimer
    • support cancellation token in callback

closes #164

@oising oising changed the title initial work to make existing tests pass for 8.2 Update for Orleans 8.2 Jul 12, 2024
@jkonecki
Copy link
Member

Hi @oising , are you working on RegisterGrainTimer? If so, do you have any ETA? Would you like some help?

@oising
Copy link
Contributor Author

oising commented Jul 16, 2024

Hi @oising , are you working on RegisterGrainTimer? If so, do you have any ETA? Would you like some help?

Yeah, that's the one. I think I'm okay? It will basically work the same as the legacy timer. The grain timer is meant to respect interleaving rules but I don't believe testkit does in general, so I don't have much to do to implement.

@seniorquico
Copy link
Collaborator

The grain timer is meant to respect interleaving rules but I don't believe testkit does in general

That's correct, the TestKit does not implement any special threading controls. It's up to the unit test implementer to ensure the grain instance is correctly called in a single-threaded fashion. (And anyone looking for managed single-threaded execution should turn to the Orleans TestCluster.)

@oising
Copy link
Contributor Author

oising commented Jul 17, 2024

@jkonecki @seniorquico I'll have the PR ready for review for end of day today.

@oising oising marked this pull request as ready for review July 17, 2024 21:28
@oising
Copy link
Contributor Author

oising commented Jul 17, 2024

Ready for first review.

@jkonecki
Copy link
Member

Looks good to me, thank you! Leaving to @seniorquico to review and approve.

@seniorquico seniorquico merged commit cf64b8d into OrleansContrib:main Jul 19, 2024
2 checks passed
@oising oising deleted the orleans82 branch July 20, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Orleans 8.2
3 participants