Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All,
After some months away from this repo, I decided to give it a final shot at a working implementation.
As many issues have pointed out, the ggml submodule pointed to an old, no-longer-referenced commit hash of ggml. Furthermore, the forward pass was not working, and several bugs still needed to be fixed.
This pull request introduces several key changes to the repository:
bark
->encodec
->ggml
. This means there is only one git submodule in the repo pointing to Encodec. Previously, bark depended on two different versions (from distinct commit hashes) of ggml (one for Bark, one for Encodec). This has been removed and will fix issues faced by users who mentioned they could not clone the repo.n_steps
->step_idx
), which truncates the audio output.nn
was passed asn_threads
and vice versa). This solves the poor audio output quality.