Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbg: fix the forward pass #139

Merged
merged 7 commits into from
Apr 10, 2024
Merged

dbg: fix the forward pass #139

merged 7 commits into from
Apr 10, 2024

Conversation

PABannier
Copy link
Owner

@PABannier PABannier commented Apr 10, 2024

Hi All,

After some months away from this repo, I decided to give it a final shot at a working implementation.

As many issues have pointed out, the ggml submodule pointed to an old, no-longer-referenced commit hash of ggml. Furthermore, the forward pass was not working, and several bugs still needed to be fixed.

This pull request introduces several key changes to the repository:

  • Simplifying the dependency graph: bark -> encodec -> ggml. This means there is only one git submodule in the repo pointing to Encodec. Previously, bark depended on two different versions (from distinct commit hashes) of ggml (one for Bark, one for Encodec). This has been removed and will fix issues faced by users who mentioned they could not clone the repo.
  • Fix a sneaky mistake in the forward pass of the coarse model (n_steps -> step_idx), which truncates the audio output.
  • Fix a mistake in the forward pass of the fine model (two arguments had their order inverted in a function call, nn was passed as n_threads and vice versa). This solves the poor audio output quality.
  • Convert all the Bark weights in a single file instead of having 3 separate files for each GPT model.
  • Adapt the quantization script to read from a single file instead of 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant