Fix e2e test for forks #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JSKitty
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Forks need access to secrets to run e2e tests, since git lfs requires authentication.
To prevent misuse, a PR needs to be approved first, by adding a safe-to-e2e-test tag. This is probably not strictly needed, as secrets are not shared as env variables in the dependencies install stage, but this protects us from people potentially spamming our lfs server with requests.
The PR needs to be merged to before the new workflow can run, I will push it to my fork as proof that it works:
https://github.com/Duddino/MyPIVXWallet/actions/runs/13568301553/job/37926505880 (e2e test works for master branch)
https://github.com/Duddino/MyPIVXWallet/actions/runs/13568258366/job/37926358958 (e2e test works for PR opened by another fork)