Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local events #543

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Local events #543

merged 2 commits into from
Mar 12, 2025

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Mar 11, 2025

Abstract

Change wallets to local events.
This is needed for #542, as multiple wallet instances events clash with each other

Testing

General wallet testing. The affected events are:

  • new-tx
  • balance-update
  • transparent-sync-status-update
  • shield-sync-status-update
  • shield-loaded-from-disk
  • shield-transaction-creation-update

Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit e3e0ee9
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/67d035f2d3dfe200086e4d9d
😎 Deploy Preview https://deploy-preview-543--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Duddino Duddino added Cleanup Removal and/or light refactoring of code safe-to-e2e-test labels Mar 11, 2025
Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK e3e0ee9

Code is good, object-based wallets along with a "de-globalisation" of MPW makes things much cleaner and isolates wallets nicely.

Tested various things on-chain, no errors, events are good.

@Duddino Duddino merged commit d5a96fd into PIVX-Labs:master Mar 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Removal and/or light refactoring of code safe-to-e2e-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants