Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Refactor] Use shield nomenclature instead of shielded #2077

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Fuzzbawls
Copy link
Collaborator

This changes instances of shielded/Shielded/SHIELDED to drop the ed suffix, resulting in both shorter RPC command names and more consistency with our branding of the SHIELD protocol.

The first commit does most of the changes, and is a scripted diff. The second commit is a basic file renaming, and the third cleans up the whitespace misalignments caused by the first commit.

-BEGIN VERIFY SCRIPT-
sed -i 's/shielded/shield/g' src/*.h src/*.cpp src/*/*.h src/*/*.cpp src/*/*/*.h src/*/*/*.cpp src/qt/forms/*.ui src/qt/pivx/forms/*.ui test/functional/*.py ;
sed -i 's/Shielded/Shield/g' src/*.h src/*.cpp src/*/*.h src/*/*.cpp src/*/*/*.h src/*/*/*.cpp src/qt/forms/*.ui src/qt/pivx/forms/*.ui test/functional/*.py ;
sed -i 's/SHIELDED/SHIELD/g' src/*.h src/*.cpp src/*/*.h src/*/*.cpp src/*/*/*.h src/*/*/*.cpp src/qt/forms/*.ui src/qt/pivx/forms/*.ui test/functional/*.py ;
-END VERIFY SCRIPT-
@Fuzzbawls Fuzzbawls self-assigned this Dec 19, 2020
@Fuzzbawls Fuzzbawls changed the title [Refactor] Use shied nomenclature instead of shielded [Refactor] Use shield nomenclature instead of shielded Dec 19, 2020
furszy added a commit that referenced this pull request Dec 21, 2020
51db288 Only use one set of parentheses for optional arguments (Fuzzbawls)
b38077a [RPC] Use "shield" nomenclature instead of "shielded" (Fuzzbawls)

Pull request description:

  Alternative to #2077 that limits the scope to the RPC interface (and unit/functional tests that exercise the RPC interface)

  Drop the "ed" suffix in the RPC scope, changes commands like
  `getnewshieldedaddress` to `getnewshieldaddress`.

  Also in blockchain informational calls; `shielded_pool_value` and
  `shieldedsupply` become `shield_pool_value` and `shieldsupply`
  respectively.

ACKs for top commit:
  random-zebra:
    utACK 51db288
  furszy:
    utACK 51db288

Tree-SHA512: adc57ef2c9bfa3f06840c9fccca0570ed39724376828880c8d4249412ca700d2de71eac33c7af31163788bacc5e4649c2bd15de9415288a780488ead596ed702
@Fuzzbawls Fuzzbawls marked this pull request as draft December 21, 2020 05:22
@Fuzzbawls Fuzzbawls changed the title [Refactor] Use shield nomenclature instead of shielded [WIP][Refactor] Use shield nomenclature instead of shielded Dec 21, 2020
@Fuzzbawls Fuzzbawls added this to the Future milestone Dec 21, 2020
@random-zebra random-zebra modified the milestones: Future, 5.1.0 Jan 17, 2021
@Fuzzbawls Fuzzbawls modified the milestones: 5.1.0, Future Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants