fix: route snapshot missing entries fix #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
A Preview PR in PanDev repo has been created. You can view it here. |
acelebanski
requested review from
FoSix,
alperenkose,
adambaumeister and
horiagunica
as code owners
alperenkose
reviewed
Feb 8, 2024
We had identical issue with FIB entries when ECMP was used, nice catch @alperenkose! Updated the PR accordingly. |
adambaumeister
approved these changes
Feb 14, 2024
alperenkose
approved these changes
Feb 16, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
## [0.3.4](v0.3.3...v0.3.4) (2024-03-07) ### Features * bgp peers snapshot comparison ([#154](#154)) ([4fec622](4fec622)) ### Bug Fixes * calculate_diff_on_dicts to Support Integer Values for ARP Table ttl ([#153](#153)) ([47ebea5](47ebea5)) * **firewall_proxy/is_panorama_connected:** Added fix for panorama check for FWs in version PAN-OS 11 or later ([#159](#159)) ([e617dbc](e617dbc)) * route snapshot missing entries fix ([#146](#146)) ([d946462](d946462))
|
🎉 This PR is included in version 0.3.4 🎉 The release is available on PyPI and GitHub release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The route table snapshot was missing entries when ECMP routes (differed only by next-hop) were present. This was because dict key generation was based only on VR name, destination CIDR and interface (if applicable). This PR adds next-hop IP address or name to dict key, so the keys are unique every time.
Motivation and Context
#56
How Has This Been Tested?
It has been tested with example python scripts.
Types of changes
Checklist