Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get_jobs exception when single job entry #165

Merged

Conversation

alperenkose
Copy link
Collaborator

Description

Fixes FirewallProxy.get_jobs() method to handle jobs response with a single entry as dict (instead of list).

See #164 for details.

Motivation and Context

Fixes #164 and #124

How Has This Been Tested?

Tested on firewalls with example scripts.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link

github-actions bot commented Apr 4, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  panos_upgrade_assurance
  firewall_proxy.py
Project Total  

This report was generated by python-coverage-comment-action

@alperenkose alperenkose self-assigned this Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

A Preview PR in PanDev repo has been created. You can view it here.

@alperenkose alperenkose linked an issue Apr 4, 2024 that may be closed by this pull request
Copy link
Collaborator

@adambaumeister adambaumeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@acelebanski acelebanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alperenkose alperenkose merged commit 7650bbb into main Apr 8, 2024
8 checks passed
@alperenkose alperenkose deleted the 164-readiness-check-for-jobs-throws-exception-for-single-job branch April 8, 2024 09:55
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
## [0.3.5](v0.3.4...v0.3.5) (2024-04-10)

### Bug Fixes

* get_jobs exception when single job entry ([#165](#165)) ([7650bbb](7650bbb))
@horiagunica
Copy link
Collaborator

🎉 This PR is included in version 0.3.5 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readiness check for jobs throws exception for single job entry job check failing when run after a reboot
4 participants