fix: Failing snapshots of FWs with no BGP peers #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelebanski
requested review from
alperenkose,
adambaumeister and
horiagunica
as code owners
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
A Preview PR in PanDev repo has been created. You can view it here. |
michalbil
approved these changes
Apr 14, 2024
alperenkose
approved these changes
Apr 15, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
## [0.3.6](v0.3.5...v0.3.6) (2024-04-17) ### Bug Fixes * Failing snapshots of FWs with no BGP peers ([#167](#167)) ([035aa99](035aa99))
|
🎉 This PR is included in version 0.3.6 🎉 The release is available on PyPI and GitHub release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release v0.3.4 introduced BGP peers information to snapshots. Function didn't handle well a situation where the firewalls didn't have any BGP peers. Added additional if statement to handle that.
Motivation and Context
As above.
How Has This Been Tested?
Tested with examples present in the repo.
Types of changes
Checklist