-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from in- to excludes for resource inclusion #141
base: main
Are you sure you want to change the base?
Switch from in- to excludes for resource inclusion #141
Conversation
09fe510
to
e20e0ad
Compare
Removed the extension as per jmp's suggestions. Consumers of paperweight hence may only edit this by directly editing the task. |
6907cc6
to
c397481
Compare
As nearly all resources found in the vanilla jar are desired to be included in paper, an include list is not ideal. Instead, this commit changes the copy resource tasks to an exclude-based filter.
c397481
to
9cc1c49
Compare
as a sanity check, can you try to generate a before and after list of files that we include? |
I'll generate a diff 👍 |
After building the re-obfuscated server using
The manifest changed as I stored my changes to paper to use paperweight in its own branch 👍 |
nice, so no other files, perfect |
Reopening this open since afaict the new pipeline uses excludes but some parts of pw still use includes? Need investigation later - low priority |
As nearly all resources found in the vanilla jar are desired to be
included in paper, an include list is not ideal. Instead, this commit
changes the copy resource tasks to an exclude-based filter.