NServiceBus step by step tutorial cleanup #6903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasohlund
commented
Nov 10, 2024
| } | ||
|
|
||
| #region InputLoopService | ||
|
|
||
| public class InputLoopService(IMessageSession messageSession, ILogger<InputLoopService> logger) : BackgroundService |
There was a problem hiding this comment.
Since we are interacting with the console anyway I figured that it would be more consistent to continue to use Console.WriteLine rather than mixing with logging
andreasohlund
commented
Nov 10, 2024
| ## Handling events | ||
|
|
||
| Create a handler class by implementing `IHandleMessages<T>` where `T` is the type of the event message. | ||
|
|
||
| snippet: EventHandler | ||
|
|
||
| > [!NOTE] |
There was a problem hiding this comment.
Since all transports we currently support (since msmq is not out of support) supports native pubsub I felt that this part was not relevant for a tutorial
andreasohlund
commented
Nov 10, 2024
| @@ -20,7 +20,7 @@ In this first lesson, which should take 10-15 minutes, you will create your firs | |||
|
|
|||
| Let's build something simple to give NServiceBus a try. | |||
|
|
|||
| This tutorial uses NServiceBus version 8, .NET 6, and assumes an up-to-date installation of [Visual Studio 2022](https://www.visualstudio.com/downloads/). | |||
| This tutorial uses NServiceBus version 9, .NET 8, and assumes an up-to-date installation of [Visual Studio 2022](https://www.visualstudio.com/downloads/). | |||
|
|
|||
| > [!NOTE] | |||
There was a problem hiding this comment.
I'm unsure if this note makes sense since this is targeted at users learning to use our latest version.
|
@nix-bohon FYI since I know you are going through the tutorials |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of preparing to run the 2-day NSB course, I went through the tutorials and found some things to clean up.
All solutions have been smoke-tested
I will make corresponding changes to https://github.com/Particular/Workshop.NServiceBus
Related cleanup of the saga tutorial #6898