Compute neighbor distance #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schroedtert
force-pushed
the
neighbors-distance
branch
2 times, most recently
from
2082fe9 to
5dfdd1a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
schroedtert
force-pushed
the
neighbors-distance
branch
from
5dfdd1a to
de0963a
Compare
schroedtert
commented
Feb 22, 2025
schroedtert
commented
Feb 22, 2025
schroedtert
force-pushed
the
neighbors-distance
branch
4 times, most recently
from
3c8bbaa to
43c290b
Compare
chraibi
reviewed
Feb 25, 2025
chraibi
requested changes
Feb 28, 2025
schroedtert
force-pushed
the
neighbors-distance
branch
from
43c290b to
d10a500
Compare
chraibi
previously approved these changes
Mar 6, 2025
mirakuepper
reviewed
Mar 6, 2025
notebooks/user_guide.ipynb
Outdated
| @@ -3176,14 +3176,21 @@ | |||
| "We define two pedestrians as neighbors if their Voronoi polygons ($V_i$, $V_j$) touch at some point, in case of *PedPy* they are touching if their distance is below 1mm.\n", | |||
| "As basis for the computation one can either use the uncut or cut Voronoi polygons.\n", | |||
| "When using the uncut Voronoi polygons, pedestrian may be detected as neighbors even when their distance is quite large in low density situation.\n", | |||
| "Therefor, it is recommended to use the cut Voronoi polygons, where the cut-off radius can be used to define a maximal distance between neighboring pedestrians.\n", | |||
| "Therefor, it is recommended to use the cut Voronoi polygons, where the cut-off radius can be used to define a maximal distance between neighboring pedestrians." | |||
There was a problem hiding this comment.
Added the missing E
Also add the (preferable) option to give the neighbors not as a list, but as rows. This way they can later better be used in other computations.
schroedtert
force-pushed
the
neighbors-distance
branch
from
d10a500 to
ef3e5c3
Compare
chraibi
previously approved these changes
Mar 11, 2025
mirakuepper
reviewed
Mar 11, 2025
schroedtert
force-pushed
the
neighbors-distance
branch
from
ef3e5c3 to
e1fd39d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #246