Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the support of convex indicator for feasible sets bounded by a radius #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ErwanMeunier
Copy link

@ErwanMeunier ErwanMeunier commented Oct 30, 2024

I added and documented the support of convex indicator for radiali bounded feasible sets. The way I added the support allows to add diameter and radius constraints simultaneously. I don't know if it is a good thing or not from the POV of maintainers.

Cheers,
Erwan

@ErwanMeunier ErwanMeunier changed the title Added the support of convex indicator for feasible set bounded by a radius Added the support of convex indicator for feasible sets bounded by a radius Oct 30, 2024
@AdrienTaylor
Copy link
Collaborator

Hello @ErwanMeunier !

Thanks for the update :) Just a quick comment: I think it makes sense to add a new point and to center the radius condition at this point (so that the set is not necessarily centered at 0).

About our POV: we implemented it several times (but did not update it here) as radius-type conditions are sometimes more convenient than diameter-type ones. So thanks a lot for the effort!

Cheers,

@ErwanMeunier
Copy link
Author

Hello @AdrienTaylor,

I've committed an updated version based on your feedback. In summary, there are now two options for the radius conditions:

  1. If the user specifies a center for ConvexIndicatorFunction(.), the conditions are defined around this point.
  2. If no center is provided (center=None), the origin is assumed to be the center of the feasible set.

Let me know if there's anything further I can refine. 😉

Cheers,
Erwan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants