Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts/artifacts): fix check-tiup.sh #3238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wuhuizuo
Copy link
Collaborator

Compatibility to run for version lower then v8.4.0

Signed-off-by: wuhuizuo [email protected]

Compatibility to run for version lower then v8.4.0

Signed-off-by: wuhuizuo <[email protected]>
Copy link

ti-chi-bot bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wuhuizuo, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from purelind November 14, 2024 12:25
Copy link

ti-chi-bot bot commented Nov 14, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key changes made in this pull request are:

  • Added support for versions lower than v8.4.0.
  • Added pump and drainer to the tiup_pkgs list if the version is lower than v8.4.0.

Overall, the changes look good and there are no potential problems that I can see. However, there are a few suggestions that I have:

  • It would be helpful to include some unit tests to ensure that the changes made are working as expected.
  • Consider adding some comments to the code to make it easier for others to understand the changes made.
  • Double-check the formatting of the code to ensure consistency with the existing codebase.

Other than these suggestions, the pull request looks good to me and I would recommend merging it once the suggestions have been addressed.

@ti-chi-bot ti-chi-bot bot added the size/M label Nov 14, 2024
@wuhuizuo
Copy link
Collaborator Author

tested manually.

@wuhuizuo
Copy link
Collaborator Author

fix the issue we found in releasing for v8.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant