Preparation for Boost 1.87, flag change for GCC 14 #6166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some stuff from Boost's asio library has been removed after Boost 1.86. The documentation says that it has been deprecated, but no compiler warnings are shown. This page explains what is considered "old" and what should be used instead: https://www.boost.org/doc/libs/1_86_0/doc/html/boost_asio/net_ts.html - io_service was simply an alias (typedef) for io_context - make_address replaces from_string - resolver.resolve and connect work a bit different now, see also https://www.boost.org/doc/libs/1_86_0/doc/html/boost_asio/tutorial/tutdaytime1/src.html
With the previous flag, GCC 14 displays many warnings like "warning: the mangled name of ... changed between ‘-fabi-version=17’ and ‘-fabi-version=19’ [-Wabi]" I think these warnings are not useful for us. Since PCL 1.15.0 will not be ABI-compatible to PCL 1.14.1 anyway, these name changes do not matter AFAIK.
larshg
approved these changes
Nov 15, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commit messages for details