Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements Shouldn't show Polymer's internal API #147

Open
manolo opened this issue Aug 28, 2017 · 4 comments
Open

Elements Shouldn't show Polymer's internal API #147

manolo opened this issue Aug 28, 2017 · 4 comments

Comments

@manolo
Copy link
Member

manolo commented Aug 28, 2017

Description

Elements directly extending the Polymer.Element, shouldn't show methods listed in Polymer.ElementMixin or Polymer.PropertyEffects

Expected outcome

Create a new element with polymer init and add iron-component-page to its index.html.
Since the element does not have any method, the API should look:

screen shot 2017-08-28 at 11 11 07

Actual outcome

The API of Polymer.Element is listed instead

screen shot 2017-08-28 at 11 12 35

@manolo
Copy link
Member Author

manolo commented Aug 28, 2017

Note that just when the simple element extends an empty mixin, the problem is fixed.

  /**
   * @polymerMixin
   */
  Foo = superClass => class FooMixin extends superClass {
  };
class KkElement extends Foo(Polymer.Element) {
...

Probably the issue might be fixed in the analyzer.

@jsilvermist
Copy link

Something I would really like to see which would fix this nicely is to add checkbox's to enable/disable each source of inherited properties/methods so you can focus on just what you care about.

@abdonrd
Copy link
Member

abdonrd commented Nov 30, 2017

Friendly ping to @aomarks. 🙂

@armujahid
Copy link

@manolo Another one liner workaround is:
class SomeElement extends (class extends Polymer.Element {})

Reference: Polymer/tools#1566 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants