-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest iron-component-page. #950
Conversation
Review status: 0 of 28 files reviewed at latest revision, 8 unresolved discussions, some commit checks broke. index.html, line 5 at r1 (raw file):
vaadin-grid vaadin-grid-column-group.html, line 13 at r1 (raw file):
One warning is enough (in vaadin-grid.html) vaadin-grid-column.html, line 345 at r1 (raw file):
One warning is enough (in vaadin-grid.html) vaadin-grid-filter.html, line 28 at r1 (raw file):
One warning is enough (in vaadin-grid.html) vaadin-grid-outer-scroller.html, line 34 at r1 (raw file):
One warning is enough (in vaadin-grid.html) vaadin-grid-scroller.html, line 13 at r1 (raw file):
One warning is enough (in vaadin-grid.html) vaadin-grid-selection-column.html, line 23 at r1 (raw file):
One warning is enough (in vaadin-grid.html) vaadin-grid-sorter.html, line 87 at r1 (raw file):
One warning is enough (in vaadin-grid.html) Comments from Reviewable |
It's because the
I didn't see a way for excluding those behaviours by adding any annotation. Apparently the only way is not to pass them as arguments to the polymer cli, hence we need to maintain somehow a file with the list of the classes to analyse. Trying to figure out why internal API is shown in certain cases. Review status: 0 of 28 files reviewed at latest revision, 8 unresolved discussions, some commit checks broke. Comments from Reviewable |
I meant that they aren’t used by grid at all and the files can be deleted. Not a blocker for this PR Comments from Reviewable |
Review status: 0 of 30 files reviewed at latest revision, 8 unresolved discussions, some commit checks broke. index.html, line 5 at r1 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Done. vaadin-grid-column-group.html, line 13 at r1 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Done. vaadin-grid-column.html, line 345 at r1 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Done. vaadin-grid-filter.html, line 28 at r1 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Done. vaadin-grid-outer-scroller.html, line 34 at r1 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Done. vaadin-grid-scroller.html, line 13 at r1 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Done. vaadin-grid-selection-column.html, line 23 at r1 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Done. vaadin-grid-sorter.html, line 87 at r1 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Done. Comments from Reviewable |
Reviewed 17 of 28 files at r1, 13 of 13 files at r2. Comments from Reviewable |
It is not parsed by analyser since the approach for adding super.observers seems breaking the parser
Connected to #878
This change is