Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select items #457

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

Westbrook
Copy link
Contributor

@Westbrook Westbrook commented Jun 23, 2017

Fixes #436
Relates to #361 (would make any batch selecting therein also not be slow)

Relies on:
Polymer/polymer#4699
Polymer/polymer#4705

Adds code paths and tests to support selecting all of the items in the list or batch selecting a subset of the list. Further the ideas introduces in #437, this relies on extensions to both Polymer 1.x and 2.x to empower array-selector with selectItems and selectAll functionality and forks the application of that code as needed in this hybrid component.

@Westbrook
Copy link
Contributor Author

Based on the response from the Polymer team in Polymer/polymer#4699 (comment) would a PR that included a custom iron-list-selector element be something that would be acceptable? Trying to see whether I should push back on that comment or whether that seems reasonable that this level of responsibility be passed down to the iron-list component.

I guess one alternate possibility would be to have a stand alone component/repo that handled these responsibilities and then require it in iron-list but I’m not sure the right place to expect that to be managed. Thoughts?

@Westbrook
Copy link
Contributor Author

Would that still block this PR on 1.x not having this capability? Can we move to a non-hybrid iron-list, yet? Just trying to figure out the right way to move this forward. Thanks for any suggestions.

@keanulee
Copy link
Contributor

I would lean towards just baking iron-list-selector functionality right into iron-list if that's possible. Having different code paths to maintain hybrid compatibility would be acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants