More performant attempt at solving #300 #487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keanulee figured I should ping you, believe you conceded to now having ownership of iron-list to me during the summit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@blasten how does this hold up instead? Figured if we leave it up to the implementor then the performance hit is on them, in my specific case I actually only need 2 properties to update so just calling notifyPath on those two is the only hit I actually need, just finished testing (moving to hybrid for my element) and it seems to work perfectly fine, at least for user interactions, having some weird issues with programatic updates but that's something I did, not iron-list.