Fix embeded templates #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… querySelectorAll to find selectable nodes.
…be tests should be fixed.
…DistributedElements Tests failing in firefox are because the page isn't ready. Added WebComponentsReady. Repeat tests fail polymer's "set" wasn't used in test.
Bring master up to date.
… querySelectorAll to find selectable nodes.
…be tests should be fixed.
…DistributedElements Tests failing in firefox are because the page isn't ready. Added WebComponentsReady. Repeat tests fail polymer's "set" wasn't used in test.
…lector into fix-embeded-templates
| var nodes = Polymer.dom(this).queryDistributedElements(this.selectable || '*'); | ||
| var nodes; | ||
| if (this.selectable) | ||
| nodes = this.querySelectorAll(this.selectable); |
There was a problem hiding this comment.
I don't think native querySelectorAll is how we should find items given that it won't be possible to perform selection into the composed tree when using native shadow DOM.
|
Sorry I don't have a ton to say at the moment, there's a handful of other PRs I'm in the middle of checking out. The intended use case for this PR is pretty strictly nested templates and not general selection of descendants, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue request #47 also added test to test deep repeat template embedding.