Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to jobol/mustach #10

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Switch to jobol/mustach #10

merged 2 commits into from
Sep 18, 2023

Conversation

steve-chavez
Copy link
Member

steve-chavez
steve-chavez commented Sep 17, 2023
View reviewed changes
test/expected/plmustache.out
Comment on lines +43 to +45
hello
------------------------------------------------------
Hello, 1, 3.4 and {"abc": "xyz"}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to the switch, this is now handled correctly.

steve-chavez
steve-chavez commented Sep 18, 2023
View reviewed changes
nix/mustach.nix Outdated
Comment on lines 11 to 17
# TODO use upstream when https://gitlab.com/jobol/mustach/-/merge_requests/31 is merged
src = fetchFromGitLab {
owner = "steve-chavez";
repo = pname;
rev = "affb1a97cde6e00bef95a4d65f7afbc3ff66df67";
sha256 = "sha256-VMADeL8xzvSivtJ3FP8cJ9XsVR4o+QxTtLfg/gdGBE0=";
};
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged!

@steve-chavez steve-chavez merged commit 40bed98 into master Sep 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Related work - move to jobol/mustach Mustache comments are not handled well
1 participant
@steve-chavez