Refine the description generation using comments on database objects` #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenceisla
force-pushed
the
fix-description
branch
from
43486cd
to
db7fb28
Compare
| @@ -13,6 +13,18 @@ select case when type like any(array['character', 'character varying', 'text']) | |||
| else 'string' end; | |||
| $$; | |||
|
|
|||
| create or replace function postgrest_unfold_comment(comm text) returns text[] | |||
There was a problem hiding this comment.
Is there a unit test for this function?
There was a problem hiding this comment.
Ah, no. In fact, I think none of the functions have unit tests.
But it makes sense for the functions inside utils.sql to have them, at least. I think they could be added in another PR. I'll open an issue for those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
titleanddescriptionwhen there was noCOMMENTon the schema