[Feature] Add ability to set a slug for a deployment schedule #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to add some validation to the slug field to ensure it doesn't have spaces and whatnot. |
|
@desertaxle LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to create a unique slug for a deployment schedule. This slug allows the users to create meaningful identifiers for schedules. This is useful with the recent addition of parameter overrides since two schedules could run at the same frequency with different parameters. The slug will also be used as the created by display value for auto-scheduled runs.
Here's what it looks like in action:
deployment.schedule.slug.demo.mov