disallow "private" imports #14890
Closed
disallow "private" imports #14890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
commented
Aug 12, 2024
| lint.extend-select = ["I"] | ||
| lint.preview = true | ||
| lint.extend-select = ["I", "PLC2701"] | ||
| lint.explicit-preview-rules = true |
There was a problem hiding this comment.
"only use preview rules we explicitly include in extend-select"
zzstoatzz
commented
Aug 12, 2024
|
|
||
| # Do not enforce line length; black does this for code and we do not care about comments / docs | ||
| lint.ignore = ["E501"] | ||
|
|
||
| [lint.per-file-ignores] | ||
| # Do not enforce usage and import order rules in init files | ||
| "__init__.py" = ["E402", "F401", "I"] | ||
| "__init__.py" = ["E402", "F401", "I", "PLC2701"] | ||
| "**/{tests,docs}/*" = ["F841", "PLC2701"] |
There was a problem hiding this comment.
"don't worry about private imports in tests" e.g. from prefect._internal
CodSpeed Performance ReportMerging #14890 will not alter performanceComparing Summary
|
zzstoatzz
force-pushed
the
no-import-private-name
branch
from
d2106b4
to
1819641
Compare
|
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
|
This pull request was closed because it has been stale for 14 days with no activity. If this pull request is important or you have more to add feel free to re-open it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use a preview
ruffrule (PLC2701) to disallow "private" imports, since we should try to keep the use of some thing_footo the place in which its definedand make ruff happy in some assorted cases found by running
pre-commit run --all-filesalso updates
ruffin thepre-commitconfig