Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where task cache storage is misconfigured #15433

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix bug where task cache storage is misconfigured #15433

merged 1 commit into from
Sep 19, 2024

Conversation

desertaxle
Copy link
Member

ResultStore.from_task mistakenly uses the key_storage from a cache policy to configure result_storage instead of metadata_storage. This PR rectifies that.

@desertaxle desertaxle added the fix A fix for a bug in an existing feature label Sep 19, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 19, 2024

CodSpeed Performance Report

Merging #15433 will not alter performance

Comparing fix-task-key-storage (65c14ab) with main (54f6d06)

Summary

✅ 3 untouched benchmarks

@desertaxle desertaxle marked this pull request as ready for review September 19, 2024 15:47
@desertaxle desertaxle merged commit e248442 into main Sep 19, 2024
35 checks passed
@desertaxle desertaxle deleted the fix-task-key-storage branch September 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzstoatzz zzstoatzz zzstoatzz approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

Assignees
No one assigned
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desertaxle @zzstoatzz