Update blob_storage.py #15435
Open
Update blob_storage.py #15435
+82
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedmeqlad99
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
zzstoatzz
reviewed
Sep 19, 2024
|
|
||
| return blob | ||
|
|
||
|
|
||
| @task |
There was a problem hiding this comment.
this appears to be a duplicate of the below function?
zzstoatzz
reviewed
Sep 19, 2024
There was a problem hiding this comment.
hi @mohamedmeqlad99 - thank you for the PR!
you'll need to install the pre-commit hooks as outlined here, which will catch stuff like the duplicate task definition blob_storage_list or non-conforming syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the Azure Blob Storage integration within the Prefect library by refining error handling, improving logging, and updating documentation for clarity and consistency. The following changes have been made:
Enhanced Error Handling: Added exception handling for ResourceNotFoundError in blob_storage_download and blob_storage_upload functions to provide clearer error messages.
Improved Logging: Updated logging messages to include additional context and details about errors and actions.
Refined Documentation: Enhanced docstrings for better readability and consistency across the functions.
Code Readability: Improved code structure and comments for better readability and maintainability.