Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] feat: Starts trigger description with deployment type trigger #16952

Closed
wants to merge 1 commit into from

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 3, 2025

Mostly focused on the UI aspect of rendering a trigger's details. (Will revisit the logic part on rendering correctly based on the trigger field)

Screenshot 2025-02-03 at 3 56 01 PM

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@devinvillarosa devinvillarosa added the DONT MERGE This PR shouldn't be merged (yet) label Feb 3, 2025
@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 3, 2025
@devinvillarosa devinvillarosa force-pushed the start-description-details branch 2 times, most recently from 565ed3f to cf93bb8 Compare February 3, 2025 23:57
@devinvillarosa devinvillarosa removed the DONT MERGE This PR shouldn't be merged (yet) label Feb 3, 2025
);
};

function getDeploymentTriggerStatus(
Copy link
Contributor Author

@devinvillarosa devinvillarosa Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic will most likely be reworked once I understand the whole mapping mechanism for an automation trigger. Mostly trying to get the UI working given a basic automation trigger

@devinvillarosa devinvillarosa marked this pull request as ready for review February 4, 2025 00:00
@devinvillarosa devinvillarosa force-pushed the start-description-details branch from cf93bb8 to 289ceee Compare February 4, 2025 00:32
@devinvillarosa devinvillarosa force-pushed the start-description-details branch from 289ceee to 36c269b Compare February 4, 2025 17:01
@devinvillarosa devinvillarosa force-pushed the start-description-details branch from 36c269b to 2c47abe Compare February 4, 2025 18:11
@devinvillarosa devinvillarosa deleted the start-description-details branch February 27, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants