Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] chore: Deprecates notifications route from react webapp #16989

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[UI v2] chore: Deprecates notifications route from react webapp #16989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions ui-v2/src/components/ui/app-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,6 @@ export function AppSidebar() {
)}
</Link>
</SidebarMenuItem>
<SidebarMenuItem>
<Link to="/notifications">
{({ isActive }) => (
<SidebarMenuButton asChild isActive={isActive}>
<span>Notifications</span>
</SidebarMenuButton>
)}
</Link>
</SidebarMenuItem>
<SidebarMenuItem>
<Link to="/concurrency-limits">
{({ isActive }) => (
Expand Down
26 changes: 0 additions & 26 deletions ui-v2/src/routeTree.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import { Route as rootRoute } from './routes/__root'
import { Route as VariablesImport } from './routes/variables'
import { Route as SettingsImport } from './routes/settings'
import { Route as NotificationsImport } from './routes/notifications'
import { Route as EventsImport } from './routes/events'
import { Route as DashboardImport } from './routes/dashboard'
import { Route as BlocksImport } from './routes/blocks'
Expand Down Expand Up @@ -53,12 +52,6 @@ const SettingsRoute = SettingsImport.update({
getParentRoute: () => rootRoute,
} as any)

const NotificationsRoute = NotificationsImport.update({
id: '/notifications',
path: '/notifications',
getParentRoute: () => rootRoute,
} as any)

const EventsRoute = EventsImport.update({
id: '/events',
path: '/events',
Expand Down Expand Up @@ -239,13 +232,6 @@ declare module '@tanstack/react-router' {
preLoaderRoute: typeof EventsImport
parentRoute: typeof rootRoute
}
'/notifications': {
id: '/notifications'
path: '/notifications'
fullPath: '/notifications'
preLoaderRoute: typeof NotificationsImport
parentRoute: typeof rootRoute
}
'/settings': {
id: '/settings'
path: '/settings'
Expand Down Expand Up @@ -454,7 +440,6 @@ export interface FileRoutesByFullPath {
'/blocks': typeof BlocksRouteWithChildren
'/dashboard': typeof DashboardRoute
'/events': typeof EventsRoute
'/notifications': typeof NotificationsRoute
'/settings': typeof SettingsRoute
'/variables': typeof VariablesRoute
'/automations/create': typeof AutomationsCreateRoute
Expand Down Expand Up @@ -483,7 +468,6 @@ export interface FileRoutesByTo {
'/': typeof IndexRoute
'/dashboard': typeof DashboardRoute
'/events': typeof EventsRoute
'/notifications': typeof NotificationsRoute
'/settings': typeof SettingsRoute
'/variables': typeof VariablesRoute
'/automations/create': typeof AutomationsCreateRoute
Expand Down Expand Up @@ -514,7 +498,6 @@ export interface FileRoutesById {
'/blocks': typeof BlocksRouteWithChildren
'/dashboard': typeof DashboardRoute
'/events': typeof EventsRoute
'/notifications': typeof NotificationsRoute
'/settings': typeof SettingsRoute
'/variables': typeof VariablesRoute
'/automations/create': typeof AutomationsCreateRoute
Expand Down Expand Up @@ -546,7 +529,6 @@ export interface FileRouteTypes {
| '/blocks'
| '/dashboard'
| '/events'
| '/notifications'
| '/settings'
| '/variables'
| '/automations/create'
Expand Down Expand Up @@ -574,7 +556,6 @@ export interface FileRouteTypes {
| '/'
| '/dashboard'
| '/events'
| '/notifications'
| '/settings'
| '/variables'
| '/automations/create'
Expand Down Expand Up @@ -603,7 +584,6 @@ export interface FileRouteTypes {
| '/blocks'
| '/dashboard'
| '/events'
| '/notifications'
| '/settings'
| '/variables'
| '/automations/create'
Expand Down Expand Up @@ -634,7 +614,6 @@ export interface RootRouteChildren {
BlocksRoute: typeof BlocksRouteWithChildren
DashboardRoute: typeof DashboardRoute
EventsRoute: typeof EventsRoute
NotificationsRoute: typeof NotificationsRoute
SettingsRoute: typeof SettingsRoute
VariablesRoute: typeof VariablesRoute
AutomationsCreateRoute: typeof AutomationsCreateRoute
Expand All @@ -659,7 +638,6 @@ const rootRouteChildren: RootRouteChildren = {
BlocksRoute: BlocksRouteWithChildren,
DashboardRoute: DashboardRoute,
EventsRoute: EventsRoute,
NotificationsRoute: NotificationsRoute,
SettingsRoute: SettingsRoute,
VariablesRoute: VariablesRoute,
AutomationsCreateRoute: AutomationsCreateRoute,
Expand Down Expand Up @@ -695,7 +673,6 @@ export const routeTree = rootRoute
"/blocks",
"/dashboard",
"/events",
"/notifications",
"/settings",
"/variables",
"/automations/create",
Expand Down Expand Up @@ -732,9 +709,6 @@ export const routeTree = rootRoute
"/events": {
"filePath": "events.tsx"
},
"/notifications": {
"filePath": "notifications.tsx"
},
"/settings": {
"filePath": "settings.tsx"
},
Expand Down
9 changes: 0 additions & 9 deletions ui-v2/src/routes/notifications.tsx
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ui-v2/tests/app.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ describe("Navigation tests", () => {
["/variables", "Variables"],
["/automations", "Automations"],
["/events", "Event Feed"],
["/notifications", "Notifications"],
["/concurrency-limits", "Concurrency"],
["/settings", "Settings"],
])("can navigate to %s", async (path, text) => {
Expand Down