Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add overloads for run_task #17448

Merged
merged 1 commit into from
Mar 11, 2025
Merged

add overloads for run_task #17448

merged 1 commit into from
Mar 11, 2025

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Mar 11, 2025

in preparation for solving #17388

wait_for is going to be tricky because we can't put it in the signature of anything that takes P.args and P.kwargs without it breaking type safety in the same way submit and map are currently broken

Copy link

codspeed-hq bot commented Mar 11, 2025

CodSpeed Performance Report

Merging #17448 will not alter performance

Comparing run-task-overloads (c63bce1) with main (1fedfca)

Summary

✅ 2 untouched benchmarks

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think wait_for might need to become an attribute on a task to keep it out of any function signatures.

@zzstoatzz zzstoatzz merged commit b958b0f into main Mar 11, 2025
52 checks passed
@zzstoatzz zzstoatzz deleted the run-task-overloads branch March 11, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants