Update utils.py #7588
Closed
Update utils.py #7588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KumoLiu
reviewed
Apr 1, 2024
monai/transforms/utils.py
Outdated
| @@ -642,6 +643,63 @@ def generate_label_classes_crop_centers( | |||
| return ensure_tuple(centers) | |||
|
|
|||
|
|
|||
| def combineMCtIandGLCCC( | |||
There was a problem hiding this comment.
Would be better to use a more meaningful name, such as map_and_generate_sampling_centers.
There was a problem hiding this comment.
I would second here that we need a much more descriptive name here. It would also help to state the dimensions input tensors must have and what the dimensions mean in the docstring. Thanks!
There was a problem hiding this comment.
I'll change the name, Thanks!
|
Thanks for the PR, please fix the format and DCO issue, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add combineMCtIandGLCCC()
From the request "A utility function to generate sampling points #6704"
#6704