Fix: upgrade x/crypto for CVE-2024-45337 #270
Closed
+33
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! It seems we also need to drop support for older Go versions in order to upgrade here. I can investigate whether that's possible. However, we don't use the SSH functionality from x/crypto in this repository, so I don't believe we're actually vulnerable to the mentioned CVE. |
|
ok, so, I'll close it for now and feel free to investigate the Go version upgrade. My intention was in general to update that x/crypto lib to satisfy security CI tools which detects the old version dependency regardless of usage the functionality or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading x/crypto lib due to CVE-2024-45337 found in version < 0.31.0
go mod graphsays that modulegithub.com/cloudflare/circlis also using thex/cryptobut it'd require upgrade of go version and a lot of other indirect dependencies are updated, so I don't want to touch it.