Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address intermittent TeeStream test failure #3465

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

jsiirola
Copy link
Member

@jsiirola jsiirola commented Feb 5, 2025

Fixes # .

Summary/Motivation:

This makes an attempt at addressing an intermittent test failure in the TeeStream buffering tests. We are occasionally seeing instances where pyomo/common/tests/test_tee.py::TestBuffering_noCapture::test_buffered_stdout_flush fails because the flush() does not appear to actually flush the output stream. This PR doesn't actually fix the underlying issue and instead adds an automatic retry before failing the test.

Changes proposed in this PR:

  • Automatically retry pyomo/common/tests/test_tee.py::TestBuffering_noCapture::test_buffered_stdout_flush if the first attempt would have led to a failure.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.66%. Comparing base (8a50553) to head (98fbb97).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3465      +/-   ##
==========================================
+ Coverage   88.19%   88.66%   +0.47%     
==========================================
  Files         880      880              
  Lines      100594   101307     +713     
==========================================
+ Hits        88715    89827    +1112     
+ Misses      11879    11480     -399     
Flag Coverage Δ
linux 86.19% <ø> (+0.01%) ⬆️
osx 76.19% <ø> (+0.01%) ⬆️
other 86.72% <ø> (+0.02%) ⬆️
win 84.67% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blnicho blnicho merged commit cd778c5 into Pyomo:main Feb 5, 2025
34 checks passed
@jsiirola jsiirola deleted the buffer-test-retry branch February 5, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants