Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple dispatch for relational expression generation #3483

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jsiirola
Copy link
Member

Fixes # .

Summary/Motivation:

This is a continuation of the work moving Pyomo expression generation to use multiple dispatch for more efficient / standardized argument processing. This migrates the relational expression generation. Overall, it provides more standardized and efficient argument processing. Overall performance on the performance test suite is improved (in particular, a 3.5% improvement in create_instance:

image

Changes proposed in this PR:

  • Move relational expression generation to use multiple dispatch
  • Move some definitions (enums and dispatcher utilities) into expr_common
  • Improved solution to managing the circular dependency between relations and numeric expressions (with better code documentation)

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@jsiirola
Copy link
Member Author

(Do not attempt to squeeze this into the release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant