Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return more info about circuit separation during partitioning #304

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
32 changes: 27 additions & 5 deletions circuit_knitting/cutting/cutting_decomposition.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,24 @@
from ..utils.observable_grouping import observables_restricted_to_subsystem
from ..utils.transforms import separate_circuit
from .qpd.qpd_basis import QPDBasis
from .qpd.instructions import TwoQubitQPDGate
from .qpd.instructions import BaseQPDGate, SingleQubitQPDGate, TwoQubitQPDGate


class PartitionedCuttingProblem(NamedTuple):
"""The result of decomposing and separating a circuit and observable(s)."""

subcircuits: dict[str | int, QuantumCircuit]
bases: list[QPDBasis]
cuts: list[CutInfo]
subobservables: dict[str | int, QuantumCircuit] | None = None


class CutInfo(NamedTuple):
"""The decomposition and location information associated with one cut."""

basis: QPDBasis
gates: list[tuple[Hashable, int]] | list[int] | int


def partition_circuit_qubits(
circuit: QuantumCircuit, partition_labels: Sequence[Hashable], inplace: bool = False
) -> QuantumCircuit:
Expand Down Expand Up @@ -195,6 +202,7 @@ def partition_problem(
ValueError: An input observable acts on a different number of qubits than the input circuit.
ValueError: An input observable has a phase not equal to 1.
ValueError: The input circuit should contain no classical bits or registers.
ValueError: The input circuit should contain no SingleQubitQPDGate instances.
"""
if len(partition_labels) != circuit.num_qubits:
raise ValueError(
Expand All @@ -221,14 +229,28 @@ def partition_problem(
bases = []
i = 0
for inst in qpd_circuit.data:
if isinstance(inst.operation, SingleQubitQPDGate):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to support these for wire cutting, but they are not well-handled as of this PR, so this ValueError is appropriate. We can remove it for the wire cutting PR, if necessary

raise ValueError(
"Input circuit may not contain SingleQubitQPDGate instances."
)
if isinstance(inst.operation, TwoQubitQPDGate):
bases.append(inst.operation.basis)
inst.operation.label = inst.operation.label + f"_{i}"
i += 1

# Separate the decomposed circuit into its subcircuits
qpd_circuit_dx = qpd_circuit.decompose(TwoQubitQPDGate)
separated_circs = separate_circuit(qpd_circuit_dx, partition_labels)
subcircuits = separate_circuit(qpd_circuit_dx, partition_labels).subcircuits

# Gather the basis and location information for the cuts
cuts_dict = defaultdict(list)
for label in subcircuits.keys():
circuit = subcircuits[label]
for i, inst in enumerate(circuit.data):
if isinstance(inst.operation, BaseQPDGate):
cut_num = int(inst.operation.label.split("_")[-1])
cuts_dict[cut_num].append((label, i))
cuts = [CutInfo(basis, cuts_dict[cut_num]) for cut_num, basis in enumerate(bases)]

# Decompose the observables, if provided
subobservables_by_subsystem = None
Expand All @@ -238,8 +260,8 @@ def partition_problem(
)

return PartitionedCuttingProblem(
separated_circs.subcircuits, # type: ignore
bases,
subcircuits, # type: ignore
cuts,
subobservables=subobservables_by_subsystem,
)

Expand Down
Loading