Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unitary hack] Improve Docstrings task/quera.py #971

Closed
wants to merge 5 commits into from

Conversation

shubhusion
Copy link
Contributor

Fixes #957
Improve Docstrings, Remove Markdown Errors

Improve Docstrings, Remove Markdown Errors
@shubhusion shubhusion changed the title Improve Docstrings task/quera.py #957 [Unitary hack] Improve Docstrings task/quera.py #957 May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (9fdc8cb) to head (36f8899).

Current head 36f8899 differs from pull request most recent head 0142b80

Please upload reports for the commit 0142b80 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #971   +/-   ##
=======================================
  Coverage   89.90%   89.91%           
=======================================
  Files         110      110           
  Lines        8132     8128    -4     
=======================================
- Hits         7311     7308    -3     
+ Misses        821      820    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubhusion shubhusion changed the title [Unitary hack] Improve Docstrings task/quera.py #957 [Unitary hack] Improve Docstrings task/quera.py May 31, 2024
@shubhusion
Copy link
Contributor Author

@Roger-luo please review this

Copy link
Member

@weinbe58 weinbe58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just need to address the comments.

src/bloqade/task/quera.py Outdated Show resolved Hide resolved
src/bloqade/task/quera.py Outdated Show resolved Hide resolved
src/bloqade/task/quera.py Outdated Show resolved Hide resolved
@shubhusion
Copy link
Contributor Author

@weinbe58 I have addressed the changes as requested by you

Copy link
Member

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think like the other PR, we should have some examples demonstrating how to use these APIs instead of just plain explanations.

@Roger-luo
Copy link
Member

I'm going to comment on your other PRs with the same comment as following to avoid duplicated review comments for other reviewers:

I think you should work on #975 first instead of asking people to review other PRs, so we don't resolve duplicated issues in multiple PRs.

@shubhusion
Copy link
Contributor Author

I'm going to comment on your other PRs with the same comment as following to avoid duplicated review comments for other reviewers:

I think you should work on #975 first instead of asking people to review other PRs, so we don't resolve duplicated issues in multiple PRs.

@Roger-luo I just addressed all the requirements @weinbe58 mentioned. I am working on other PRs where you have mentioned changes related to examples.

@weinbe58 weinbe58 closed this Aug 2, 2024
@shubhusion shubhusion deleted the patch-3 branch August 5, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve docstrings
3 participants