[Unitary hack] Improve Docstrings in "task/batch" #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhusion
changed the title
weinbe58
requested changes
Jun 5, 2024
Comment on lines
-303
to
-327
| def __str__(self) -> str: | ||
| output = "" | ||
| for task_index, task_error in self.task_errors.items(): | ||
| output += ( | ||
| f"Task {task_index} failed to submit with error: " | ||
| f"{task_error.exception_type}\n" | ||
| f"{task_error.stack_trace}" | ||
| ) | ||
|
|
||
| return output | ||
|
|
||
|
|
||
| @BatchErrors.set_serializer | ||
| def _serialize(self: BatchErrors) -> Dict[str, List]: | ||
| return { | ||
| "task_errors": [ | ||
| (task_number, task_error) | ||
| for task_number, task_error in self.task_errors.items() | ||
| ] | ||
| } | ||
|
|
||
|
|
||
| @BatchErrors.set_deserializer | ||
| def _deserialize(obj: dict) -> BatchErrors: | ||
| return BatchErrors(task_errors=OrderedDict(obj["task_errors"])) |
There was a problem hiding this comment.
why did you delete this code? this is making the CI fail. Please add this code back.
There was a problem hiding this comment.
I realize I made a mistake while merging conflicts. I was updating the docstrings as part of the unitary hack issue. I will resolve it. Thanks for correcting me.
There was a problem hiding this comment.
No problem, if you need help setting up your development environment take a look at our docs page on that: https://bloqade.quera.com/latest/contributing/developing-bloqade/
There was a problem hiding this comment.
@shubhusion can I close this PR? I haven't seen any updates on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #957
Improve function docstrings and Remove markdown errors