Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docstring for RydbergHamiltonian and hamiltonian method #990

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

johnzl-777
Copy link
Collaborator

No description provided.

@johnzl-777 johnzl-777 requested a review from weinbe58 July 29, 2024 17:24
Copy link
Contributor

github-actions bot commented Jul 29, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-02 13:23 UTC

@johnzl-777 johnzl-777 mentioned this pull request Jul 29, 2024
@weinbe58 weinbe58 enabled auto-merge (squash) July 29, 2024 18:14
Copy link
Member

@weinbe58 weinbe58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add documentation to hamiltonian method?

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (e1114ac) to head (c422a1d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #990   +/-   ##
=======================================
  Coverage   89.91%   89.91%           
=======================================
  Files         110      110           
  Lines        8132     8132           
=======================================
  Hits         7312     7312           
  Misses        820      820           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnzl-777 johnzl-777 changed the title Added docstring for RydbergHamiltonian Added docstring for RydbergHamiltonian and hamiltonian method Jul 30, 2024
@johnzl-777 johnzl-777 requested a review from weinbe58 July 30, 2024 15:25
@weinbe58 weinbe58 merged commit de8013e into main Aug 2, 2024
10 checks passed
@weinbe58 weinbe58 deleted the john/add-rydberg-hamiltonian-docstring branch August 2, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants