Add CZ Gate and fix cx bug #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 92.46% 92.68% +0.21%
==========================================
Files 4 4
Lines 239 246 +7
==========================================
+ Hits 221 228 +7
Misses 18 18 ☔ View full report in Codecov by Sentry. |
|
I believe we had the same conversation about this before, this change is violating the definition of OpenQASM 2.0
please read Table I carefully https://arxiv.org/pdf/1707.03429v2.pdf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Dear Maintainers,
it seems that there has been a Bug regression and the cx bug has reappeared again.
I have improve the tests, so that the tests now include CX and cx.
Further I have also added the CZ gate.
Merging this PR, will fix the CI for PR for YaoHIR , which again will fix the notebooks for PR [PR 102 for ZXCalculus.jl]https://github.com/QuantumBFS/ZXCalculus.jl/pull/102l)