Rebase over updated upstream (Rails 7.1 compatible) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the large range of supported versions it’s beneficial to see which ones exactly do fail and why to avoid whack-a-mole debugging scenarios.
Maintaining old and unsupported combinations of Ruby + Rails has become painful (e.g. due to Ruby’s OpenSSL dependency) so remove those but add Rails 7.1 to the build matrix and fix specs.
e.g. due to flaky network conditions
…as we no longer support Rails ≤ 6.0.
This was a leftover from Rails ≤6.0 support.
Regression introduced in #5012e0d6. This change partially reverts the change such that it works for Rails 6.1/7.0 and 7.1+. In Rails 7.1+ the API for `.serialize` changed. At first using `serialize :parameters, coder: YAML, type: Hash` seems to be backwards compatible with Rails 6.1/7.0 when reading the documentation/code but there’s a subtle difference: when the 2nd positional parameter (denoting the target type) is not provided a default mechanism is used. While the defaults will use `YAML` as the coder the serialization will only occur if the column is not `NULL`. So, without an explicit type parameter `nil`/`NULL` values are not converted to `Hash`. Thus, the explicit type parameter acts as the fallback for the value itself. Fixes public-activity#386 public-activity#384 public-activity#382
oboxodo
force-pushed
the
rebase-over-updated-upstream
branch
from
014791d to
1f49035
Compare
oboxodo
changed the title
|
Closing this PR in favor of maintaining separate branches per upstream gem version. Current branches are: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebases our fork over the latest released v3.0.1 official upsteam which is updated to support Rails 7.1. Our fork onl has 1 extra commit.