-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: filter data that the suffix is serverQrl_rpc #7441
base: main
Are you sure you want to change the base?
Conversation
|
@wmertens it's my first time trying to implement this |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
@@ -798,7 +783,30 @@ export function createQwikPlugin(optimizerOptions: OptimizerOptions = {}) { | |||
return manifest; | |||
}; | |||
|
|||
return { addInjection, generateManifest }; | |||
const collectServerRpcAndCtxKindSymbols = async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's rename this to collectPublicAPI
@@ -998,6 +1006,7 @@ export const SSR_OUT_DIR = 'server'; | |||
const LIB_OUT_DIR = 'lib'; | |||
|
|||
export const Q_MANIFEST_FILENAME = 'q-manifest.json'; | |||
export const Q_SERVER_RPC_CTX_KIND_SYMBOLS_FILENAME = 'q-server-rpc-ctx-kind-symbols.json'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's call this q-public-api.json
Good start, now we need to read this file in qwik-city and only allow known symbols. Then we should also create a # Public endpoints
## `server$`
- `/xyz123`:
- parameters: foo, bar
- scope: myContext
## `formAction$`
... the dev can then check this in and will know when the API changes. |
What is it?
fixes #7313
By looking at the symbol name you can see if it's a server qrl,
Description
Checklist
pnpm change