Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue278 - Fixed top end data values missing when selecting intervals colormap type #294

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

lstillwe
Copy link
Contributor

Fixed top end data values missing when selecting intervals colormap type
Also addressed issues with upper and lower bound sliders

@@ -55,7 +55,7 @@
"@mui/joy": "^5.0.0-beta.48",
"@mui/material": "^6.1.1",
"@mui/x-date-pickers": "^7.18.0",
"@renci/apsviz-geostyler": "15.0.18",
"@renci/apsviz-geostyler": "15.0.21",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 2 low severity reported in this update

node_modules/cookie
express 3.0.0-alpha1 - 4.21.0 || 5.0.0-alpha.1 - 5.0.0
Depends on vulnerable versions of cookie
node_modules/express

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay - I'll take a look, might be in a package I can't update.

const minWidth = 45;
const maxWidth = 75;
//const minWidth = 45;
//const maxWidth = 75;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why you just commented these out if you are replacing them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! - I guess I put back them back to what they were - was tinkering with this quite a bit, couldn't read the number with some the data ranges. I wish we could auto-size to content.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like this in my code ....
//const minWidth = 45;
//const maxWidth = 75;
const minWidth = 65;
const maxWidth = 95;

//const minHeight = 250;
//const maxHeight = 350;
const minHeight = 300;
const maxHeight = 400;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new settings are producing weirdness. could have been there before tho.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha! Weird doesn't do that on my browser. I'll just put everything back to what it was. I guess you found it readable - I could not in my browser.

Copy link
Collaborator

@PhillipsOwen PhillipsOwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basic slider is allowing me to go to 0 with zero range.
image

@lstillwe
Copy link
Contributor Author

Okay will check out all this stuff. Thanks for taking a look.

@lstillwe
Copy link
Contributor Author

Delivered some updates - please take another look.

@PhillipsOwen PhillipsOwen merged commit 461a2a8 into main Oct 14, 2024
@PhillipsOwen PhillipsOwen deleted the issue278 branch October 14, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants