-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue278 - Fixed top end data values missing when selecting intervals colormap type #294
Conversation
@@ -55,7 +55,7 @@ | |||
"@mui/joy": "^5.0.0-beta.48", | |||
"@mui/material": "^6.1.1", | |||
"@mui/x-date-pickers": "^7.18.0", | |||
"@renci/apsviz-geostyler": "15.0.18", | |||
"@renci/apsviz-geostyler": "15.0.21", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are 2 low severity reported in this update
node_modules/cookie
express 3.0.0-alpha1 - 4.21.0 || 5.0.0-alpha.1 - 5.0.0
Depends on vulnerable versions of cookie
node_modules/express
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay - I'll take a look, might be in a package I can't update.
src/components/legend/legend.js
Outdated
const minWidth = 45; | ||
const maxWidth = 75; | ||
//const minWidth = 45; | ||
//const maxWidth = 75; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why you just commented these out if you are replacing them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha! - I guess I put back them back to what they were - was tinkering with this quite a bit, couldn't read the number with some the data ranges. I wish we could auto-size to content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it looks like this in my code ....
//const minWidth = 45;
//const maxWidth = 75;
const minWidth = 65;
const maxWidth = 95;
src/components/legend/legend.js
Outdated
//const minHeight = 250; | ||
//const maxHeight = 350; | ||
const minHeight = 300; | ||
const maxHeight = 400; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha! Weird doesn't do that on my browser. I'll just put everything back to what it was. I guess you found it readable - I could not in my browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay will check out all this stuff. Thanks for taking a look. |
Delivered some updates - please take another look. |
Fixed top end data values missing when selecting intervals colormap type
Also addressed issues with upper and lower bound sliders