Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where odometry was not resetting during bring-up and corrected an initial offset issue in odometry. #1055

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

GyuH13
Copy link
Contributor

@GyuH13 GyuH13 commented Feb 12, 2025

Description

Summary of Changes

  • Odom bug fix
    • joint_state.hpp
      • Added a Dynamixel wrapper argument to the constructor.
    • joint_state.cpp
      • Initialized the last_position variable in the constructor.
    • turtlebot3.cpp
      • Added a Dynamixel wrapper argument when creating the JointState object and added source code to read the control table.

Testing & Validation

This branch has been validated on the TurtleBot3 hardware with the Humble version and works properly

Copy link
Member

@robotpilot robotpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robotpilot robotpilot added the enhancement New feature or request label Feb 12, 2025
@robotpilot robotpilot assigned robotpilot and GyuH13 and unassigned robotpilot Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants