otf2 output: Build up a proper system tree #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OTF2 mandates that ACCELERATOR location groups need a ACCELERATOR_DEVICE
system tree node as parent and that the creating location group is a
PROCESS. The system tree node _class_ for the device should actually
be something like "AMD GPU" and the _name_ be "{logical_node_type_id}"
but uses currently only the same name as the location group for the
_class_.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTF2 mandates that ACCELERATOR location groups need a ACCELERATOR_DEVICE system tree node as parent and that the creating location group is a PROCESS. The system tree node class for the device should actually be something like "AMD GPU" and the name be "{logical_node_type_id}" but uses currently only the same name as the location group for the class.
What type of PR is this? (check all applicable)
Technical details
Comply to the OTF2 event/metadata model.
Added/updated tests?
Updated CHANGELOG?
Added/Updated documentation?