Tag mass replace #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
- Coverage 63.43% 60.05% -3.38%
==========================================
Files 6 6
Lines 473 458 -15
==========================================
- Hits 300 275 -25
Misses 110 110
- Partials 63 73 +10
Continue to review full report at Codecov.
|
bonedaddy
reviewed
Nov 19, 2020
| @@ -135,6 +136,19 @@ func dataKeyToCid(s string) (cid.Cid, error) { | |||
| return cid.Decode(s[1 : len(s)-len(dataSuffixKey.String())]) | |||
| } | |||
|
|
|||
| func tagKeyToCid(k datastore.Key) (cid.Cid, error) { | |||
| s := k.String() | |||
| min := 4 | |||
There was a problem hiding this comment.
would having min as a global variable be useful?
There was a problem hiding this comment.
It could, but it's only used in this one function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a convenience function to do remove and add tags in one go, without needing to provide the cids of objects to remove the tag from.
This currently does not have a progressive implementation.