Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention sample and withLatestFrom in each other's docs #7499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robintown
Copy link

withLatestFrom and sample are pretty similar: the latter just skips emitting when the sampled observable hasn't emitted anything new. I recently found myself using sample when I should've been using withLatestFrom, and would've benefited from it being linked in the docs.

withLatestFrom and sample are pretty similar: the latter just skips emitting when the sampled observable hasn't emitted anything new. I recently found myself using sample when I should've been using withLatestFrom, and would've benefited from it being linked in the docs.
Copy link

nx-cloud bot commented Oct 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit df7f53e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx compile rxjs

Sent with 💌 from NxCloud.

Copy link
Member

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, they kinda are the same, so we can include them in each other's @see section. LGTM, thanks. We will merge this once we solve issue with pipelines (it may take some time, sorry, we don't have anyone available right now to fix it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants