Feature/traceback serialization

[ksamuel]

This is the first draft of what we talked about with the KISSest solution I can think of:

• store the serialized exception in the exception dict in _result
• add a traceback property to read it if needed

I had to make assumption about the None issue I mentioned in #68 (comment) since the branch is now rebased, force pushed and deleted. I resolved to return None from the traceback property in case of complex exceptions.

The PoC contains passing tests, including types and linting, but no documentation yet, awaiting your feedback to see if this is the spirit you are looking for.

I can squash if needed of course.

[RealOrangeOne]

Thanks so much for putting this together - it'll be a great boost for usability, without much extra maintenance burdern.

I'd also recommend rebasing your branch, now I've merged some more things in.

[ksamuel]

Traceback are now strings, stylistic remarks are addressed, extranous file is removed. Typing is improved. Missing the C module stack trace for now.

[ksamuel]

I'll fix the linter later, meanwhile, is the PR going in the right direction?

[RealOrangeOne]

Definitely the right direction 🥳 Couple nits, but otherwise this is looking really nice!

[ksamuel]

Nits addressed, linting passed. Once everything matches your expectations, I'll squash and force push.

[RealOrangeOne]

Looking at the current test failures, asserting the full depth of the stacktrace is likely to cause issues, and ties the tests to how the current version of Python implements it. Given format_exception is a built-in, I'm happy to trust that it works, and just throw some assertions in for the message itself and perhaps a file path or 2.

[ksamuel]

Indeed. Especially since error messages have been the focus of improvements by Pablo Galindo Salgado. I'll make the checks more fuzzy.

[ksamuel]

Better, now we test that the data looks like we put a traceback in there, but doesn't care much about the formatting of it. I also ran the sqlite test for good measure, although I don't expect the result store to be affected in any way.

[ksamuel]

Cheers, and thanks for all the work on a very useful addition to django.