Add additional test cases for process management #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealOrangeOne
commented
Jul 23, 2024
RealOrangeOne
force-pushed
the
process-tests
branch
from
1aa2ce4
to
ae5ca22
Compare
This avoids platform-specific issues with `multiprocess`
RealOrangeOne
force-pushed
the
process-tests
branch
from
cb8b878
to
1b8d8f8
Compare
RealOrangeOne
force-pushed
the
process-tests
branch
from
a935797
to
78cf6ac
Compare
RealOrangeOne
force-pushed
the
process-tests
branch
from
fcf7c21
to
a535c28
Compare
Sending signals on Windows is surprisingly difficult. CTRL-C is handled by `SIGINT`, which is tested on other platforms and should behave the same. Improving test coverage for Windows will be a future task.
RealOrangeOne
force-pushed
the
process-tests
branch
from
a535c28
to
fe25e12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
Unfortunately, SQLite tests are now much slower, as they don't run in memory any more. I've added an extra command to try and mitigate that.
Simulating signals on Windows is rather difficult, so improvements to those tests will come later.