Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-select and active toggle to Users Table #1764

Merged
merged 13 commits into from
Mar 4, 2025
Merged

Conversation

apinkert
Copy link
Contributor

@apinkert apinkert commented Feb 19, 2025

Fixing some tests that broke because of these changes, but converting to regular PR to get some eyes on it.

Screen.Recording.2025-02-25.at.3.46.55.PM.mov

@apinkert apinkert marked this pull request as ready for review February 25, 2025 20:44
@apinkert apinkert requested a review from a team as a code owner February 25, 2025 20:44
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 58.24176% with 38 lines in your changes missing coverage. Please review.

Project coverage is 38.50%. Comparing base (55f911e) to head (f50cade).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...mart-components/user/users-list-not-selectable.tsx 50.00% 30 Missing ⚠️
src/smart-components/user/ActivateToggle.tsx 55.55% 4 Missing ⚠️
src/smart-components/user/user-table-helpers.tsx 80.00% 3 Missing ⚠️
...omponents/shared/table-composable-toolbar-view.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1764      +/-   ##
==========================================
+ Coverage   38.34%   38.50%   +0.15%     
==========================================
  Files         207      208       +1     
  Lines        5993     6067      +74     
  Branches     1553     1574      +21     
==========================================
+ Hits         2298     2336      +38     
- Misses       3478     3514      +36     
  Partials      217      217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karelhala karelhala requested a review from a team as a code owner March 4, 2025 10:11
@karelhala karelhala merged commit 6ff9f18 into master Mar 4, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants